Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump to use go1.21 #847

Merged
merged 1 commit into from
Jan 10, 2024
Merged

feat: bump to use go1.21 #847

merged 1 commit into from
Jan 10, 2024

Conversation

chenrui333
Copy link
Contributor

Description

bump to use go1.21 for build

relates to Homebrew/homebrew-core#159379

Related Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes only affecting documentation)

Checklist

  • I have tested my changes locally and ensured they are functioning properly. Please run the make build and make test commands.
  • I have added/updated unit or e2e tests to cover my changes.
  • I have updated the relevant documentation. If you change commands or arguments, run make doc-gen to generate new documentation.

@the-label-bot the-label-bot bot added kind/feature ategorizes issue or PR as related to a new feature. size/S size/S labels Jan 10, 2024
@the-label-bot The Label Bot
Copy link

the-label-bot bot commented Jan 10, 2024 •
edited
Loading

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.846 ✔️
Size M 0.899 ✔️

@the-label-bot the-label-bot bot added size/M size/M and removed size/S size/S labels Jan 10, 2024
@chenrui333
feat: bump to use go1.21
05d0b65 
Signed-off-by: Rui Chen <[email protected]>

chore: update pipelines to use go1.21

Signed-off-by: Rui Chen <[email protected]>

fix: have checkout action before setup-go action

Signed-off-by: Rui Chen <[email protected]>

bump golangci-lint to 1.54

Signed-off-by: Rui Chen <[email protected]>
@sunny0826
Copy link
Owner

@all-contributors
please add @chenrui333 for infra.

@allcontributors allcontributors bot mentioned this pull request Jan 10, 2024
Merged
sunny0826
sunny0826 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM, Thanks for your contribute !

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (779e13e) 18.87% compared to head (05d0b65) 18.87%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #847   +/-   ##
=======================================
  Coverage   18.87%   18.87%           
=======================================
  Files          21       21           
  Lines        2257     2257           
=======================================
  Hits          426      426           
  Misses       1791     1791           
  Partials       40       40
Flag Coverage Δ
unittests 18.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunny0826 sunny0826 merged commit 57c44a2 into sunny0826:master Jan 10, 2024
3 checks passed
@allcontributors AllContributors
Copy link
Contributor

@sunny0826

I've put up a pull request to add @chenrui333! 🎉

This was referenced Jan 10, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunny0826 sunny0826 sunny0826 approved these changes

Assignees
No one assigned
Labels
kind/feature ategorizes issue or PR as related to a new feature. size/M size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @sunny0826